xfs
[Top] [All Lists]

Re: [patch 02/12] Move compat ioctl structs & numbers into xfs_ioctl32.h

To: sandeen@xxxxxxxxxxx
Subject: Re: [patch 02/12] Move compat ioctl structs & numbers into xfs_ioctl32.h
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 26 Nov 2008 05:05:16 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081126032027.099506160@xxxxxxxxxxx>
References: <20081126032005.639750968@xxxxxxxxxxx> <20081126032027.099506160@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Nov 25, 2008 at 09:20:07PM -0600, sandeen@xxxxxxxxxxx wrote:
> This makes the c file less cluttered and a bit more
> readable.   Consistently name the ioctl number
> macros with "_32" and the compatibility stuctures
> with "_compat."  Rename the helpers which simply
> copy in the arg with "_copyin" for easy identification.
> 
> Finally, for a few of the existing helpers, modify them
> so that they directly call the native ioctl helper
> after userspace argument fixup.

Looks good.

<Prev in Thread] Current Thread [Next in Thread>