xfs
[Top] [All Lists]

Re: [PATCH 1/5] xfstests: fix compiler warnings

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 1/5] xfstests: fix compiler warnings
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 31 Dec 2008 04:30:09 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <495AD1EF.3080109@xxxxxxxxxxx>
References: <20081230230810.986105000@xxxxxxxxxxxxxxxxxxxxxx> <20081230230912.986540000@xxxxxxxxxxxxxxxxxxxxxx> <495AD1EF.3080109@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Dec 30, 2008 at 07:59:11PM -0600, Eric Sandeen wrote:
> Just in case this gets transplanted outside xfstests, where _GNU_SOURCE
> may not be defined on the make commandline, would it make sense to just
> put this #define inside
> 
> #ifndef _GNU_SOURCE?
> 
> Just a thought; otherwise looks good to me.

Yeah, we could.  OR we could expect people who take it outside add it
manually after some feature is missing as we do for all other programs
in xfsqa :)

<Prev in Thread] Current Thread [Next in Thread>