On Wed, Jan 07, 2009 at 08:43:10AM -0600, Eric Sandeen wrote:
> The thing is, xfs_db could in theory be used to *fix* the bad magic
> number, so refusing to continue might be a problem. But perhaps when
> invoked as xfs_admin, it should just bail out. It would be interesting
> to find where the actual failure is, though...
We have bugzilla open for this, too. I think it's reasonable to
get a warning, but not the additional problems when calling xfs_db
directly because that's a low-level tool for people that know what
But when called through wrappers like xfs_admin we should first do
the magic number check. I think the proper way to implement this
is to add an option to xfs_db to perform the magic number check,
and make sure all the wrapper scripts set it, similar to how they
already use -p <progname>.
Any volunteer to implement this? It should be fairly simple.