xfs
[Top] [All Lists]

xfsdump: specfile: remove Distribution/Packager tag

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: xfsdump: specfile: remove Distribution/Packager tag
From: Jan Engelhardt <jengelh@xxxxxxxxxx>
Date: Wed, 25 Feb 2009 11:15:10 +0100 (CET)
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090224190731.GA22910@xxxxxxxxxxxxx>
References: <alpine.LSU.2.00.0902111802320.25232@xxxxxxxxxxxxxxxxxxxxxxxxx> <20090215172417.GA20256@xxxxxxxxxxxxx> <alpine.LSU.2.00.0902191625070.20437@xxxxxxxxxxxxxxxxxxxxxxxxx> <20090224190731.GA22910@xxxxxxxxxxxxx>
Sender: jengelh@xxxxxxxxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (LSU 1167 2008-08-23)
On Tuesday 2009-02-24 20:07, Christoph Hellwig wrote:
>On Thu, Feb 19, 2009 at 04:25:20PM +0100, Jan Engelhardt wrote:
>> On Sunday 2009-02-15 18:24, Christoph Hellwig wrote:
>> 
>> >Thanks, I'll put these in.  Can you submit equivalent patches for
>> >xfsdump and dmapi, too?
>> >
>> xfsdump and dmapi git repositories seem to have no .spec files.
>
>build/rpm/xfsdump.spec.in and build/rpm/dmapi.spec.in


parent b7b66942273709925184998fb08283e279e0366f ()
commit 0ba9509a63079457a356c07017ad0591968c3ae2
Author: Jan Engelhardt <jengelh@xxxxxxxxxx>
Date:   Wed Feb 25 11:13:03 2009 +0100

specfile: remove Distribution/Packager tag

There exist a number of rpm specfile tags that make it possible to
mislead users of the produced RPM package, because its presence
overrides anything that has been specified in ~/.rpmmacros (or the
configuration files of the build system used). Such is especially
annoying when Packager:/Vendor: is put in specfiles, because it is
then almost impossible to get the name/email of the person who
_really_ did the packaging (assuming s/he set it in their
.rpmmacros).

Such similarly applies to the Distribution: tag, which is why I
suggest its removal and let the build systems provide the proper
string instead.

Signed-off-by: Jan Engelhardt <jengelh@xxxxxxxxxx>
---
 build/rpm/xfsdump.spec.in |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/build/rpm/xfsdump.spec.in b/build/rpm/xfsdump.spec.in
index 417dd84..59a6bb1 100644
--- a/build/rpm/xfsdump.spec.in
+++ b/build/rpm/xfsdump.spec.in
@@ -2,8 +2,6 @@ Summary: Administrative utilities for the XFS filesystem.
 Name: @pkg_name@
 Version: @pkg_version@
 Release: @pkg_release@
-Distribution: @pkg_distribution@
-Packager: Silicon Graphics, Inc. <http://www.sgi.com/>
 BuildRoot: @build_root@ 
 Requires: xfsprogs >= 3.0.0, attr >= 2.0.0
 Source: @pkg_name@-@pkg_version@.src.tar.gz
-- 
# Created with git-export-patch

<Prev in Thread] Current Thread [Next in Thread>