xfs
[Top] [All Lists]

[PATCH] xfstests: skip dump tests if dump utils not found

To: xfs-oss <xfs@xxxxxxxxxxx>
Subject: [PATCH] xfstests: skip dump tests if dump utils not found
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 19 Apr 2009 15:54:40 -0500
User-agent: Thunderbird 2.0.0.21 (Macintosh/20090302)
I was running xfstests on a NAS box which had no xfsdump,
and any tests which required xfsdump were failing in not-so-nice
ways:

> xfsdump not found
038      [failed, exit status 1] - output mismatch (see 038.out.bad)

I think using _notrun is a lot better:

038      [not run] xfsdump not found

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
---

diff --git a/common.dump b/common.dump
index 6d2f120..fcc4945 100644
--- a/common.dump
+++ b/common.dump
@@ -23,9 +23,9 @@ if [ -n "$DEBUGDUMP" ]; then
        [ -x $here/xfsinvutil ] && echo "Using xfstests' xfsinvutil for debug"
 fi
 
-[ "$XFSDUMP_PROG" = "" ]    && _fatal "xfsdump not found"
-[ "$XFSRESTORE_PROG" = "" ] && _fatal "xfsrestore not found"
-[ "$XFSINVUTIL_PROG" = "" ] && _fatal "xfsinvutil not found"
+[ "$XFSDUMP_PROG" = "" ]    && _notrun "xfsdump not found"
+[ "$XFSRESTORE_PROG" = "" ] && _notrun "xfsrestore not found"
+[ "$XFSINVUTIL_PROG" = "" ] && _notrun "xfsinvutil not found"
 
 # status returned for not run tests
 NOTRUNSTS=2


<Prev in Thread] Current Thread [Next in Thread>