xfs
[Top] [All Lists]

Re: [PATCH] xfstests: Allow fsx tests to run on generic filesystems

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: Allow fsx tests to run on generic filesystems
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 08 Jun 2009 11:26:52 -0500
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <20090608161646.GA14861@xxxxxxxxxxxxx>
References: <4A2D31E3.3090108@xxxxxxxxxxx> <20090608161646.GA14861@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Christoph Hellwig wrote:
> On Mon, Jun 08, 2009 at 10:44:35AM -0500, Eric Sandeen wrote:
>> There is already logic in 075 to gracefully skip nfs for fsx
>> invocations with -x (xfs-specific preallocation) - just extend
>> this to any non-xfs filesystem, and add to test 112 as well.
>>
>> Later we can change this behavior to use fallocate and include
>> more filesystems but this gets some fsx coverage for now.
>>
>> Test 127 doesn't seem to have anything xfs-specific, so mark
>> that as generic too.
> 
> Good bandaid for now, but it would be even better to get a fsx
> version using the generic prealloc calls one day :)

Will do after we're done w/ the planned fsx gyrations....

-Eric

> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 

<Prev in Thread] Current Thread [Next in Thread>