xfs
[Top] [All Lists]

Re: [PATCH] xfs_repair: check for null single-block dir buffer pointer i

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs_repair: check for null single-block dir buffer pointer in phase6
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 26 Jul 2009 17:52:28 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20090725150256.GA12148@xxxxxxxxxxxxx>
References: <4A69C660.9000604@xxxxxxxxxxx> <20090725150256.GA12148@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.22 (Macintosh/20090605)
Christoph Hellwig wrote:
> On Fri, Jul 24, 2009 at 09:34:08AM -0500, Eric Sandeen wrote:
>> @@ -2524,7 +2525,7 @@ longform_dir2_entry_check(xfs_mount_t  *mp,
>>  
>>      if (!dotdot_update) {
>>              /* check btree and freespace */
>> -            if (isblock) {
>> +            if (isblock && bplist[0]) {
>>                      xfs_dir2_block_tail_t   *btp;
>>                      xfs_dir2_leaf_entry_t   *blp;
> 
> This doesn't look quite correct to me.  Now we falls through to the
> final else statement when bplist[0] is zeroed.
> 

Oh, ugh, you're right.  Will fix that up, thanks.

-Eric

<Prev in Thread] Current Thread [Next in Thread>