xfs
[Top] [All Lists]

Re: [PATCH, RFC] xfs: batched discard support

To: Ric Wheeler <rwheeler@xxxxxxxxxx>
Subject: Re: [PATCH, RFC] xfs: batched discard support
From: Mark Lord <liml@xxxxxx>
Date: Thu, 20 Aug 2009 10:38:19 -0400
Cc: Ingo Molnar <mingo@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, jens.axboe@xxxxxxxxxx, IDE/ATA development list <linux-ide@xxxxxxxxxxxxxxx>, Neil Brown <neilb@xxxxxxx>
In-reply-to: <4A8D5442.1000302@xxxxxxxxxx>
Organization: Real-Time Remedies Inc.
References: <20090816004705.GA7347@xxxxxxxxxxxxx> <20090819203916.GA25296@xxxxxxx> <4A8CA956.2060406@xxxxxx> <4A8D5442.1000302@xxxxxxxxxx>
User-agent: Thunderbird 2.0.0.22 (X11/20090608)
Ric Wheeler wrote:

Note that returning consistent data is critical for devices that are used in a RAID group since you will need each RAID block that is used to compute the parity to continue to return the same data until you overwrite it with new data :-)

If we have a device that does not support this (or is misconfigured not to do this), we should not use those devices in an MD group & do discard against it...
..

Well, that's a bit drastic.  But the RAID software should at least
not issue TRIM commands in ignorance of such.

Would it still be okay to do the TRIMs when the entire parity stripe
(across all members) is being discarded?  (As opposed to just partial
data there being dropped)

<Prev in Thread] Current Thread [Next in Thread>