xfs
[Top] [All Lists]

Re: [PATCH] xfs: use correct log reservation when handling ENOSPC in xfs

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH] xfs: use correct log reservation when handling ENOSPC in xfs_create
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 3 Sep 2009 11:46:11 -0400
In-reply-to: <20090826113736.GA15562@xxxxxxxxxxxxx>
References: <20090826113736.GA15562@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
ping?

On Wed, Aug 26, 2009 at 07:37:36AM -0400, Christoph Hellwig wrote:
> We added the ENOSPC handling patch in xfs_create just after it got mered
> with xfs_mkdir.  Change the log reservation to the variable for either
> the create or mkdir value so it does the right thing if get here for creating
> a directory.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Index: xfs/fs/xfs/xfs_vnodeops.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_vnodeops.c    2009-08-24 11:35:52.794261954 -0300
> +++ xfs/fs/xfs/xfs_vnodeops.c 2009-08-24 11:36:25.466636450 -0300
> @@ -1479,8 +1479,8 @@ xfs_create(
>       if (error == ENOSPC) {
>               /* flush outstanding delalloc blocks and retry */
>               xfs_flush_inodes(dp);
> -             error = xfs_trans_reserve(tp, resblks, XFS_CREATE_LOG_RES(mp), 
> 0,
> -                     XFS_TRANS_PERM_LOG_RES, XFS_CREATE_LOG_COUNT);
> +             error = xfs_trans_reserve(tp, resblks, log_res, 0,
> +                             XFS_TRANS_PERM_LOG_RES, log_count);
>       }
>       if (error == ENOSPC) {
>               /* No space at all so try a "no-allocation" reservation */
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] xfs: use correct log reservation when handling ENOSPC in xfs_create, Christoph Hellwig <=