xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: update configure defaults

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: update configure defaults
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 07 Oct 2009 14:01:40 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20091006151458.GA2560@xxxxxxxxxxxxx>
References: <20091006151458.GA2560@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
Christoph Hellwig wrote:
Currenly xfsprogs has two different sets for configurating it, those
in the configure.in template, and those passed to configure by the
toplevel Makefile when just running make.

Those in the makefile make a lot more sense as they install xfsprogs
into the / vs /usr split used by most distributions, and enable multi-libs
when detected.

This patch changes the build system to also use the same defaults when
running ./configure.  To do this we get rid of some of the hacky
autoconf abuse we had in the past in xfsprogs and just use the normal
default sbindir and libdir variables for /usr/sbin an /usr/lib respecticly
and define new root_sbindir and root_libdir variables for those few
binaries installed into /.  The installation to / is disabled if the
user chooses a non-default exex prefix.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

This almost works for me in fedora, except that fedora's rpm uses a %configure
which sets --libdir=/usr/lib64 and then I end up with stuff installed in
/usr/lib6464 \o/

With this patch things are ok again if I add --disable-lib64 :


diff --git a/configure.in b/configure.in
index 35a1e6f..78ac522 100644
--- a/configure.in
+++ b/configure.in
@@ -58,7 +58,14 @@ NONE:NONE | NONE:/usr | /usr:*)
  root_sbindir='/sbin'
  AC_SUBST([root_sbindir])

-  root_libdir='/lib'
+  case $libdir in
+  *64)
+    root_libdir='/lib64'
+    ;;
+  *)
+    root_libdir='/lib'
+    ;;
+   esac
  AC_SUBST([root_libdir])
esac




<Prev in Thread] Current Thread [Next in Thread>