xfs
[Top] [All Lists]

RE: [PATCH 13/14] repair: optimize duplicate extent tracking

To: "Christoph Hellwig" <hch@xxxxxxxxxxxxx>
Subject: RE: [PATCH 13/14] repair: optimize duplicate extent tracking
From: "Alex Elder" <aelder@xxxxxxx>
Date: Thu, 22 Oct 2009 11:41:40 -0500
Cc: "Barry Naujok" <bnaujok@xxxxxxx>, <xfs@xxxxxxxxxxx>
In-reply-to: <20090902175842.081792481@xxxxxxxxxxxxxxxxxxxxxx>
Thread-index: Acor+Q+9CDpp6DX+REq/b8iv/sHOPgnOtj+A
Thread-topic: [PATCH 13/14] repair: optimize duplicate extent tracking
Christoph Hellwig wrote:
> Switch the duplicate extent tracking from an avl tree to our new btree
> implementation.  Modify search_dup_extent to find overlapping extents
> with differening start blocks instead of having the caller walk every
> possible start block.

Looks good.             -Alex

> Signed-off-by: Barry Naujok <bnaujok@xxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Index: xfsprogs-dev/repair/incore_ext.c
> ===================================================================
> --- xfsprogs-dev.orig/repair/incore_ext.c     2009-08-21 15:11:16.000000000 
> +0000
> +++ xfsprogs-dev/repair/incore_ext.c  2009-08-21 15:24:07.000000000 +0000

...

<Prev in Thread] Current Thread [Next in Thread>
  • RE: [PATCH 13/14] repair: optimize duplicate extent tracking, Alex Elder <=