xfs
[Top] [All Lists]

RE: [PATCH] xfs: Wrapped journal record corruption on read at recovery

To: "Andy Poling" <andy@xxxxxxxxxxx>
Subject: RE: [PATCH] xfs: Wrapped journal record corruption on read at recovery
From: "Alex Elder" <aelder@xxxxxxx>
Date: Tue, 3 Nov 2009 13:15:39 -0600
Cc: "John Quigley" <jquigley@xxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>
In-reply-to: <1AB9A794DBDDF54A8A81BE2296F7BDFE83AE64@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Thread-index: AcpN+Tuft9jB9P80QiemylsfQMjH1QOsCBNQAAQLGnA=
Thread-topic: Wrapped journal record corruption on read at recovery -patchattached (was Re: XFS corruption with failover)
Alex Elder wrote:
> Andy Poling wrote:
>> On Wed, 14 Oct 2009, Christoph Hellwig wrote:
>>>> It seems like the more elegant approach would be to set offset before the
>>>> first read, and then update it if the first read takes place (in case it 
>>>> was
>>>> unaligned).  That also gets rid of bufaddr, and seems like it might read
...


Andy, can you tell me the log sector
size of a file system that exhibits
this failure condition?

You can just send the output of:
    xfs_info /dev/<whatever>
if you like.  I have a suspicion
that there may still be a problem,
even with your proposed fix, and
would like to rule that possibility
out.  Basically, if log sectsz is
is > 1024 your fix is probably OK.

Thanks.

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>