xfs
[Top] [All Lists]

Re: [PATCH 3/7] xfs: rename xfs_attr_fetch to xfs_attr_get_int

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/7] xfs: rename xfs_attr_fetch to xfs_attr_get_int
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 18 Nov 2009 22:42:53 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20091114161801.612419979@xxxxxxxxxxxxxxxxxxxxxx>
References: <20091114161717.233372584@xxxxxxxxxxxxxxxxxxxxxx> <20091114161801.612419979@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
Christoph Hellwig wrote:

> Using a totally different name for the lowlevel get operation does not
> fit the _int convention used in the rest of the attr code, so rename it.
> 
> While we're at it also fix the prototype to use the normal convention
> and mark it static as it's never used outside of xfs_attr.c.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

> Index: xfs/fs/xfs/xfs_attr.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_attr.c        2009-11-12 17:10:20.047264798 +0100
> +++ xfs/fs/xfs/xfs_attr.c     2009-11-12 17:18:17.703273473 +0100
> @@ -123,9 +123,13 @@ xfs_inode_hasattr(
>   * Overall external interface routines.
>   *========================================================================*/
>  
> -int
> -xfs_attr_fetch(xfs_inode_t *ip, struct xfs_name *name,
> -             char *value, int *valuelenp, int flags)
> +STATIC int
> +xfs_attr_get_int(
> +     struct xfs_inode        *ip,
> +     struct xfs_name         *name,
> +     char                    *value,
> +     int                     *valuelenp,
> +     int                     flags)
>  {
>       xfs_da_args_t   args;
>       int             error;
> @@ -188,7 +192,7 @@ xfs_attr_get(
>               return error;
>  
>       xfs_ilock(ip, XFS_ILOCK_SHARED);
> -     error = xfs_attr_fetch(ip, &xname, value, valuelenp, flags);
> +     error = xfs_attr_get_int(ip, &xname, value, valuelenp, flags);
>       xfs_iunlock(ip, XFS_ILOCK_SHARED);
>       return(error);
>  }
> Index: xfs/fs/xfs/xfs_attr.h
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_attr.h        2009-11-12 17:10:20.056254911 +0100
> +++ xfs/fs/xfs/xfs_attr.h     2009-11-12 17:18:17.703273473 +0100
> @@ -131,7 +131,6 @@ typedef struct xfs_attr_list_context {
>   */
>  int xfs_attr_calc_size(struct xfs_inode *, int, int, int *);
>  int xfs_attr_inactive(struct xfs_inode *dp);
> -int xfs_attr_fetch(struct xfs_inode *, struct xfs_name *, char *, int *, 
> int);
>  int xfs_attr_rmtval_get(struct xfs_da_args *args);
>  int xfs_attr_list_int(struct xfs_attr_list_context *);
>  
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>