xfs
[Top] [All Lists]

Re: [PATCH v2 2/7] xfs: simplify xfs_buf_get / xfs_buf_read interfaces

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2 2/7] xfs: simplify xfs_buf_get / xfs_buf_read interfaces
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 25 Nov 2009 11:16:36 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20091124180223.GA1211@xxxxxxxxxxxxx>
References: <20091114161717.233372584@xxxxxxxxxxxxxxxxxxxxxx> <20091114161801.411213050@xxxxxxxxxxxxxxxxxxxxxx> <20091124180223.GA1211@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Nov 24, 2009 at 01:02:23PM -0500, Christoph Hellwig wrote:
> 
> Currently these lowlevel buffer cache interfaces are highly confusing
> as we have a _flags variant of each that does actually respect the flags,
> and one without _flags which has a flags argument that gets ignored and
> overriden with a default set.  Given that very few places use the default
> arguments get rid of the duplication and convert all callers to pass the
> flags explicitly.  Also remove the now confusing _flags postfix.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>