xfs
[Top] [All Lists]

Re: [PATCH] use time32_t consistently in xfsdump tree

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] use time32_t consistently in xfsdump tree
From: Bill Kendall <wkendall@xxxxxxx>
Date: Wed, 23 Dec 2009 11:15:04 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20091223133136.GA10345@xxxxxxxxxxxxx>
References: <4B300389.7020905@xxxxxxx> <20091223133136.GA10345@xxxxxxxxxxxxx>
User-agent: Thunderbird 1.5.0.14ubu (X11/20080502)
Christoph Hellwig wrote:
On Wed, Dec 23, 2009 at 09:20:59AM -0600, Bill Kendall wrote:
Reposting to fix whitespace issues introduced by mailer.

The patch looks good and applies cleanly now,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>


Some notes to look into after this patch:

 - can you provide a testcase for the problems caused by the wrong
   time_t usage?  A patch to xfstests would be perfect, but if you
   have a raw testcase I'll vounteer to wire it up.

The way I reproduced this was to do a subtree dump followed by
a dump of the inventory. On systems with a 64-bit time_t, this
will show a dump date far into the future.

# xfsdump -F -s tmp -f /dev/null /
# xfsinvutil -C | grep Session
            Session 0: valor:/ Sat Jan 29 17:45:22 2146

The dump needs to be a subtree dump since that sets a flag in
a field which is adjacent to a timestamp field in an inventory
structure. When the time32_t field was cast to a time_t *,
the flag's value was being read.

I don't know if this is worth writing a test for, however.
It catches one specific call to ctime where ctime32 should
have been used. The compiler will issue warnings for these
cases, it's just that the code was explicitly casting to
time_t * to silence the warnings.

 - why do we wrap both ctime and ctime_r?  Currently xfsdump isn't
   multithreaded so we shouldn't need it.  But if the parallel
   dump/restore ever gets merged from IRIX we need to get rid of the
   plain ctime calls.  (Btw, are there any plans for the parallel
   dump/restore port?)

There was an existing ctime_r call so I just blindly converted
it to ctime32_r. The existing ctime32 calls all come from xfsinvutil,
which will remain single-threaded even if xfsdump/restore is parallel.

However, while looking at this I noticed there's at least one case
where we do printf("...", ctime(), ctime()). That's not going to
work right -- the same value will be printed for both times. I'll
have to repost again...

No plans for the parallel port.

Bill

<Prev in Thread] Current Thread [Next in Thread>