xfs
[Top] [All Lists]

Re: [PATCH 1/3] repair: fix freespace btree record validation

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] repair: fix freespace btree record validation
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 31 Dec 2009 09:25:27 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20091201151037.381644480@xxxxxxxxxxxxxxxxxxxxxx>
References: <20091201150503.958283878@xxxxxxxxxxxxxxxxxxxxxx> <20091201151037.381644480@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Dec 01, 2009 at 10:05:04AM -0500, Christoph Hellwig wrote:
> MAXEXTLEN is a limit for the bmap btree extent length, not for the freespace
> btrees which can fill out the whole u32.  Remove the check which makes
> repair skip too large freespace extents.  Also add warnings for freespace
> btree records that fail the remaining validations.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>