On Thu, Jan 14, 2010 at 12:42:12PM -0600, Alex Elder wrote:
> Dave Chinner wrote:
> > This is the previous set of patches all put together in the one series
> > for the current xfs-dev tree.
> > Patch 10 is a new patch - it embeds the busy extent list into the perag
> > structure rather than leaving as a separate allocation.
> All 10 patches look good. I am adding the following descriptions
> to these patches which lacked them:
> [03/10] XFS: Convert filestreams code to use per-ag get/put routines
> Use xfs_perag_get() and xfs_perag_put() in the filestreams code.
I'd consier that redundant and therefore unnecssary. I don't put
a descriptio in if the subject line describes the patch
sufficiently. It seems to be a pretty common practise, actually.
> [09/10] xfs: handle ENOMEM correctly during initialisation of perag structures
> Add proper error handling in case an error occurs while initializing
> new perag structures for a mount point. The mount structure is
> restored to its previous state by deleting and freeing any perag
> structures added during the call.
That describes what the code does, which I'd also consider