xfs
[Top] [All Lists]

Re: [PATCH 1/4] [PATCH 1/4] xfs: merge xfs_lrw.c into xfs_file.c

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/4] [PATCH 1/4] xfs: merge xfs_lrw.c into xfs_file.c
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 17 Feb 2010 03:14:03 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20100217033626.GI28392@xxxxxxxxxxxxxxxx>
References: <20100215094445.528696829@xxxxxxxxxxxxxxxxxxxxxx> <20100215094603.932254045@xxxxxxxxxxxxxxxxxxxxxx> <20100217033626.GI28392@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Feb 17, 2010 at 02:36:26PM +1100, Dave Chinner wrote:
> On Mon, Feb 15, 2010 at 04:44:46AM -0500, Christoph Hellwig wrote:
> > Currently the code to implement the file operations is split over two small
> > files.  Merge the content of xfs_lrw.c into xfs_file.c to have it in one
> > place.  Note that I haven't done various cleanups that are possible after
> > this yet, they will follow in the next patch.  Also the function 
> > xfs_dev_is_read_only which was in xfs_lrw.c before really doesn't fit in
> > here at all and was moved to xfs_mount.c.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Looks good to me, so:
> 
> Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>
> 
> As an additional step, perhaps it be a good idea to get rid of
> xfs_lrw.h as well?

Yes, that's a good idea, I'll prepare a patch to do that.

<Prev in Thread] Current Thread [Next in Thread>