xfs
[Top] [All Lists]

Re: builddefs.in

To: Lasse Kliemann <lasse-private-2010@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: builddefs.in
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 22 Mar 2010 11:33:25 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100321141349.GE1827@xxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20100321141349.GE1827@xxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Sun, Mar 21, 2010 at 03:13:50PM +0100, Lasse Kliemann wrote:
> Using 3.1.1.
> 
> When configured with a '--prefix', the build fails:
> 
> [...]
>     [CC]     linux.lo
>     [LD]     libxfs.la
> libtool: link: only absolute run-paths are allowed
> gmake[2]: *** [libxfs.la] Error 1
> gmake[1]: *** [libxfs] Error 2
> make: *** [default] Error 2
> 
> Calling 'make' in 'libxfs' reveals that '-rpath' option is used 
> with no argument. The attached patch remedies this. Indeed, with 
> this patch the correct argument is given to '-rpath', at least in 
> 'libxfs' subdirectory. 
> 
> It also remedies a similar problem when installing executables 
> into '.../sbin' directory.

> diff --git a/include/builddefs.in b/include/builddefs.in
> index cc75b5d..801b09e 100644
> --- a/include/builddefs.in
> +++ b/include/builddefs.in
> @@ -52,8 +52,8 @@ datarootdir = @datarootdir@
>  top_builddir = @top_builddir@
>  
>  PKG_SBIN_DIR = @sbindir@
> -PKG_ROOT_SBIN_DIR = @root_sbindir@
> -PKG_ROOT_LIB_DIR= @root_libdir@@libdirsuffix@
> +PKG_ROOT_SBIN_DIR = @sbindir@
> +PKG_ROOT_LIB_DIR= @libdir@@libdirsuffix@

This is against the intent of the whole ROOT_LIB/SBIN_DIR
mechnism as it makes them equivalent to the normal ones.
It seems we have some problem generatin the correct @root_sbindir@ /
@root_libdir@ paths in the autoconf macros for your use case, I'll
look into that once I get a bit of time.

<Prev in Thread] Current Thread [Next in Thread>
  • builddefs.in, Lasse Kliemann
    • Re: builddefs.in, Christoph Hellwig <=