xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix might_sleep() warning when initialising per-ag tree

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix might_sleep() warning when initialising per-ag tree
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 27 May 2010 08:21:49 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1274925493-31401-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1274925493-31401-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, May 27, 2010 at 11:58:13AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The use of radix_tree_preload() only works if the radix tree was initialised
> without the __GFP_WAIT flag. The per-ag tree uses GFP_NOFS, so does not 
> trigger
> allocation of new tree nodes from the preloaded array. Hence it enters the
> allocator with a spinlock held and triggers the might_sleep() warnings.
> 
> Reported-by; Chris Mason <chris.mason@xxxxxxxxxx>
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>