xfs
[Top] [All Lists]

Re: [PATCH] xfstests: have getfacl(1) report numeric id's

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: have getfacl(1) report numeric id's
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 02 Aug 2010 12:47:44 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100801141549.GB10192@xxxxxxxxxxxxx>
References: <201007302154.o6ULsNdm008915@xxxxxxxxxxxxxxxxxxxxxx> <20100801141549.GB10192@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Sun, 2010-08-01 at 10:15 -0400, Christoph Hellwig wrote:
> On Fri, Jul 30, 2010 at 04:54:23PM -0500, Alex Elder wrote:
> > This patch arranges for calls to getfacl(1) to be given the "-n"
> > flag, which requests that user and group id's be listed numerically
> > rather than using names.  The affected test output files are also
> > updated to indicate the effect of the change.
> > 
> > This eliminates some spurious output differences I was seeing, due
> > to the presence of NIS in my test environment.
> > 
> > Signed-off-by: Alex Elder <aelder@xxxxxxx>
> 
> Looks good,
> 
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 
> I wonder if this usage should be documented somewhere for future tests.
> 

Same goes for the use of _cat_passwd and _cat_group.
I'll add something to the "README" file in the "Test
script environment" section and will post that shortly.

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] xfstests: have getfacl(1) report numeric id's, Alex Elder <=