xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfsrestore: turn off NODECHK

To: wkendall@xxxxxxx
Subject: Re: [PATCH 1/2] xfsrestore: turn off NODECHK
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 14 Oct 2010 13:45:11 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20101012215400.430780299@xxxxxxx>
References: <20101012215322.749700656@xxxxxxx> <20101012215400.430780299@xxxxxxx>
Reply-to: aelder@xxxxxxx
On Tue, 2010-10-12 at 16:53 -0500, wkendall@xxxxxxx wrote:
> plain text document attachment (no_node_check)
> The NODECHK macro should only be enabled as needed for
> development/debugging.  Having it on limits xfsrestore to
> 268 million directory entries instead of 4 billion. 

I was going to suggest you leave it in the Makefile in
commented-out form, perhaps with an explanation that
it's available for development.  But since NODECHK is
only ever referenced inside "restore/node.c", maybe
such a thing could be done inside that file instead.

I.e., something like:

/*
 * NODECHK can be enabled for development and debugging
 * in order to enforce additional checks on handles
 * when nodes are mapped, unmapped, and freed.  It should
 * not be used for production code, it cuts into the number
 * of directory entries xfsrestore can handle.
 */
/* #define NODECHK */

I'll leave it up to you whether you think that's worth
doing (and if so, let me know).  Either way:

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Signed-off-by: Bill Kendall <wkendall@xxxxxxx>
> 
> Index: xfsdump-kernel.org/restore/Makefile
> ===================================================================
> --- xfsdump-kernel.org.orig/restore/Makefile
> +++ xfsdump-kernel.org/restore/Makefile
> @@ -103,7 +103,7 @@ LLDLIBS = $(LIBUUID) $(LIBHANDLE) $(LIBA
>  LTDEPENDENCIES = $(LIBRMT)
>  
>  LCFLAGS = -DRESTORE -DRMT -DBASED -DDOSOCKS -DINVCONVFIX -DPIPEINVFIX \
> -     -DEOMFIX -DSESSCPLT -DWHITEPARSE -DNODECHK -DDIRENTHDR_CHECKSUM \
> +     -DEOMFIX -DSESSCPLT -DWHITEPARSE -DDIRENTHDR_CHECKSUM \
>       -DF_FSSETDM
>  
>  default: depend $(LTCOMMAND)
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs



<Prev in Thread] Current Thread [Next in Thread>