xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix 108 golden output

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix 108 golden output
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 09 Dec 2010 15:19:39 -0600
Cc: xfs@xxxxxxxxxxx, branto@xxxxxxxxxx
In-reply-to: <20101110125855.GA18357@xxxxxxxxxxxxx>
References: <20101110125855.GA18357@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Wed, 2010-11-10 at 07:58 -0500, Christoph Hellwig wrote:
> The new common scratch mount filter produces slightly different
> whitespaces than the old home grown filter, so adjust the golden
> output.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

I found out why this is happening.  I get no
such error, and Dave Chinner said he wasn't seeing
it either.

xfs_quota is formatting its output such that the
second and later columns always align at a certain
offset from the beginning of the line.  As a result,
path names assigned as SCRATCH_DEV of different
lengths will produce different (filtered) output,
with more or fewer blanks between SCRATCH_DEV and
the usage number.

Boris Ranto has proposed a change that would
add the "-b" flag to diff when checking output
against golden output.  That should fix it, but
it's possible we *want* differences in white
space to matter in some cases.  Have to look
into this.

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>