xfs
[Top] [All Lists]

Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 20 Dec 2010 06:34:58 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1292215483-18224-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1292215483-18224-1-git-send-email-david@xxxxxxxxxxxxx> <1292215483-18224-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Dec 13, 2010 at 03:44:32PM +1100, Dave Chinner wrote:
> -             __field(void *, reserve_headq)
> -             __field(void *, write_headq)
> +             __field(void *, reserveq)
> +             __field(void *, writeq)

To repeat my question from the last review:  what's the point in logging
this at all?  There's not much we can do with it from trace-cmd / perf
output.  What might be more useful is a list_empty() boolean flag.

<Prev in Thread] Current Thread [Next in Thread>