xfs
[Top] [All Lists]

Re: [PATCH 04/12] xfs: combine grant heads into a single 64 bit integer

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 04/12] xfs: combine grant heads into a single 64 bit integer
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 20 Dec 2010 06:40:20 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1292215483-18224-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1292215483-18224-1-git-send-email-david@xxxxxxxxxxxxx> <1292215483-18224-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Dec 13, 2010 at 03:44:35PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Prepare for switching the grant heads to atomic variables by
> combining the two 32 bit values that make up the grant head into a
> single 64 bit variable.  Provide wrapper functions to combine and
> split the grant heads appropriately for calculations and use them as
> necessary.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Minor nitpick:

> +     if ((tail_cycle == head_cycle) && (head_bytes >= tail_bytes)) {
> +             free_bytes = log->l_logsize - (head_bytes - tail_bytes);
> +     } else if ((tail_cycle + 1) < head_cycle) {

Lots of superflous braces in the if statements.

<Prev in Thread] Current Thread [Next in Thread>