xfs
[Top] [All Lists]

Re: [PATCH 05/12] xfs: use wait queues directly for the log wait queues

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/12] xfs: use wait queues directly for the log wait queues
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 20 Dec 2010 06:40:59 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1292215483-18224-6-git-send-email-david@xxxxxxxxxxxxx>
References: <1292215483-18224-1-git-send-email-david@xxxxxxxxxxxxx> <1292215483-18224-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Dec 13, 2010 at 03:44:36PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The log grant queues are one of the few places left using sv_t
> constructs for waiting. Given we are touching this code, we should
> convert them to plain wait queues. While there, convert all the
> other sv_t users in the log code as well.
> 
> Seeing as this removes the last users of the sv_t type, remove the
> header file defining the wrapper and the fragments that still
> reference it.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>