xfs
[Top] [All Lists]

Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 21 Dec 2010 11:55:41 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20101220113458.GA12806@xxxxxxxxxxxxx>
References: <1292215483-18224-1-git-send-email-david@xxxxxxxxxxxxx> <1292215483-18224-2-git-send-email-david@xxxxxxxxxxxxx> <20101220113458.GA12806@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Dec 20, 2010 at 06:34:58AM -0500, Christoph Hellwig wrote:
> On Mon, Dec 13, 2010 at 03:44:32PM +1100, Dave Chinner wrote:
> > -           __field(void *, reserve_headq)
> > -           __field(void *, write_headq)
> > +           __field(void *, reserveq)
> > +           __field(void *, writeq)
> 
> To repeat my question from the last review:  what's the point in logging
> this at all?  There's not much we can do with it from trace-cmd / perf
> output.  What might be more useful is a list_empty() boolean flag.

Oh, I missed that when running through all the comments. Thanks for
pointing it out again - I'll fix it this time.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>