xfs
[Top] [All Lists]

Re: [PATCH] Xfstests: make 014 only run on xfs

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] Xfstests: make 014 only run on xfs
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 01 Feb 2011 17:48:57 -0600
Cc: Josef Bacik <josef@xxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20110127005945.GE21311@dastard>
References: <1296050729-17316-1-git-send-email-josef@xxxxxxxxxx> <20110127005945.GE21311@dastard>
Reply-to: aelder@xxxxxxx
On Thu, 2011-01-27 at 11:59 +1100, Dave Chinner wrote:
> On Wed, Jan 26, 2011 at 09:05:29AM -0500, Josef Bacik wrote:
> > This test relies on mounting with -o allocsize, which is an xfs specific 
> > mount
> > option, so make the test only work on xfs.  Thanks,
> 
> Oh, sorry, my fault. Perhaps something like this instead?

Since test 014 reportedly works on other filesystem
types provided the allocsize option isn't provided,
Dave's version looks better.

Josef will you please take a look over--and preferably
test--what Dave proposed, and if you agree offer your
signoff?

Thanks.

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>