xfs
[Top] [All Lists]

Re: [PATCH v4, 09/16] xfsprogs: metadump: don't loop on too many dups

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH v4, 09/16] xfsprogs: metadump: don't loop on too many dups
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 3 Mar 2011 16:07:31 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1298657624.1990.6986.camel@doink>
References: <201102182121.p1ILL1fw029119@xxxxxxxxxxxxxxxxxxxxxx> <20110224015509.GW3166@dastard> <1298657624.1990.6986.camel@doink>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Feb 25, 2011 at 12:13:44PM -0600, Alex Elder wrote:
> Don't just loop indefinitely when an obfuscated name comes up as a
> duplicate.  Count the number of times we've found a duplicate and if
> if it gets excessive despite choosing names at random, just give up
> and use the original name without obfuscation.
> 
> Technically, a typical 5-character name has 255 other names that can
> have the same hash value.  But the algorithm doesn't hit all
> possible names (far from it) so duplicates are still possible.
> 
> Signed-off-by: Alex Elder <aelder@xxxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Updates (v4):
> - Rearranged things a bit so that if too many duplicates are
>   encountered, a warning gets emitted.
>     
> Dave already signed off on it but the update was different enough I
> thought I should post it once more.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH v4, 09/16] xfsprogs: metadump: don't loop on too many dups, Dave Chinner <=