xfs
[Top] [All Lists]

Re: [PATCH 4/4] xfs: reduce the number of pagb_lock roundtrips in xfs_al

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 4/4] xfs: reduce the number of pagb_lock roundtrips in xfs_alloc_clear_busy
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 27 Apr 2011 15:45:30 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1303923381.2056.58.camel@doink>
References: <20110424190613.404786382@xxxxxxxxxxxxxxxxxxxxxx> <20110424190657.249817918@xxxxxxxxxxxxxxxxxxxxxx> <1303923381.2056.58.camel@doink>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Apr 27, 2011 at 11:56:21AM -0500, Alex Elder wrote:
> Perhaps you have other plans that make the model you
> have here more appropriate though.  Let me know
> if you intend to re-submit, otherwise I'll just take
> this version.

The discard support will call xfs_alloc_busy_clear twice for
each list, once to clear all items that don't need discarding,
and a second pass once we're done with the discards.  Keeping
the sorting separate just seems cleaner at that point.

<Prev in Thread] Current Thread [Next in Thread>