xfs
[Top] [All Lists]

Re: [PATCH] xfstests: coalesce contiguous extents in extent map output

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] xfstests: coalesce contiguous extents in extent map output
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 28 Apr 2011 12:08:46 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <dd1c0747731332fed9637bc01d6c6de369a7fe6f.1303412098.git.aelder@xxxxxxx>
References: <dd1c0747731332fed9637bc01d6c6de369a7fe6f.1303412098.git.aelder@xxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Thu, Apr 21, 2011 at 01:55:03PM -0500, Alex Elder wrote:
> The specific set of extent sizes allocated to a file is not always
> deterministic.  In particular, sometimes a range of unwritten blocks
> is covered by a single extent, while in other cases it might be
> represented by multiple consecutive unwritten extents.  This can
> result in spurious errors being reported in tests that check file
> extent maps.
> 
> Add a filter that finds adjacent extents in what gets produced for
> fiemap and bmap output and coalesces them as if all consective
> extents of the same time were really just one extent.  (Note that
> as implemented here this applies to all extent types, not just
> unwritten extents.)
> 
> Update the golden output for test 242 to reflect the change.

Looks sane. Does Josef's new test need the same golden output
treatment?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>