xfs
[Top] [All Lists]

Re: [PATCH]: [xfstests] v2: Make ext2 requirement explicit for test 049

To: sekharan@xxxxxxxxxx
Subject: Re: [PATCH]: [xfstests] v2: Make ext2 requirement explicit for test 049
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Fri, 10 Jun 2011 17:12:22 -0500
Cc: XFS Mailing List <xfs@xxxxxxxxxxx>
In-reply-to: <1307737668.7661.438.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <1307737668.7661.438.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10
On 6/10/11 3:27 PM, Chandra Seetharaman wrote:
> Test 049 depends on ext2 module being supported by the kernel.
> 
> This patch makes it a explicit, instead of failing the test with
> obscure message.
> 
> Signed-Off-By: Chandra Seetharaman <sekharan@xxxxxxxxxx>

committed in the xfstests-dev tree on kernel.org, thanks!

-Eric

> ---
> 
> diff --git a/049 b/049
> index 3d3f030..c6c4faa 100755
> --- a/049
> +++ b/049
> @@ -64,6 +64,7 @@ _require_nobigloopfs
>  _require_nonexternal
>  _require_scratch
>  _require_loop
> +_require_ext2
>  
>  rm -f $seq.full
>  
> diff --git a/common.rc b/common.rc
> index c510c66..44c746d 100644
> --- a/common.rc
> +++ b/common.rc
> @@ -769,6 +769,24 @@ _require_loop()
>      fi
>  }
>  
> +# this test requires ext2 filesystem support
> +#
> +_require_ext2()
> +{
> +    if [ "$HOSTOS" != "Linux" ]
> +    then
> +     _notrun "This test requires linux for ext2 filesystem support"
> +    fi
> +
> +    modprobe ext2 >/dev/null 2>&1
> +    if grep ext2 /proc/filesystems >/dev/null 2>&1
> +    then
> +     :
> +    else
> +     _notrun "This test requires ext2 filesystem support"
> +    fi
> +}
> +
>  # this test requires that (large) loopback device files are not in use
>  #
>  _require_nobigloopfs()
> 
> 

<Prev in Thread] Current Thread [Next in Thread>