xfs
[Top] [All Lists]

Re: [PATCH 1/5] repair: handle repair of image files on large sector siz

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/5] repair: handle repair of image files on large sector size filesystems
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 9 Oct 2011 19:52:40 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1318201910-11144-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1318201910-11144-1-git-send-email-david@xxxxxxxxxxxxx> <1318201910-11144-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Oct 10, 2011 at 10:11:46AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Because repair uses direct IO, it cannot do IO smaller than a sector
> on the underlying device. When repairing a filesystem image, the
> filesystem hosting the image may have a sector size larger than the
> sector size of the image, and so single image sector reads and
> writes will fail.

Does it?  Given that the loop driver uses buffered I/O that would be
unexpected behaviour.  I'll try to reproduce it as soon as my 4k
disk is available again.

<Prev in Thread] Current Thread [Next in Thread>