xfs
[Top] [All Lists]

Re: [PATCH 4/5] repair: don't cache large blkmap allocations

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/5] repair: don't cache large blkmap allocations
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 10 Oct 2011 11:14:00 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111009234809.GB13527@xxxxxxxxxxxxx>
References: <1318201910-11144-1-git-send-email-david@xxxxxxxxxxxxx> <1318201910-11144-5-git-send-email-david@xxxxxxxxxxxxx> <20111009234809.GB13527@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Oct 09, 2011 at 07:48:09PM -0400, Christoph Hellwig wrote:
> > +   /* consider more than 100k extents rare */
> > +   if (blkmap->naexts < 100 * 1024)
> > +           return;
> 
> 100k extents still seems like a fairly high number.  Otherwise looks
> okay.

But not unreasonable for a filesystem full of torrents ;)

> (If only we had a non-sucky threaded memory allocator in userspace..)

Perhaps we should look at the talloc code from ccan?

Cheers,

Dave.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>