xfs
[Top] [All Lists]

Re: [PATCH 1/5] repair: handle repair of image files on large sector siz

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/5] repair: handle repair of image files on large sector size filesystems
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 9 Oct 2011 20:19:09 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20111010001708.GP3159@dastard>
References: <1318201910-11144-1-git-send-email-david@xxxxxxxxxxxxx> <1318201910-11144-2-git-send-email-david@xxxxxxxxxxxxx> <20111009235240.GD13527@xxxxxxxxxxxxx> <20111010001708.GP3159@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Oct 10, 2011 at 11:17:08AM +1100, Dave Chinner wrote:
> > Does it?  Given that the loop driver uses buffered I/O that would be
> > unexpected behaviour.  I'll try to reproduce it as soon as my 4k
> > disk is available again.
> 
> My 3TB, RAID6 based image storage filesystem has a 4k sector size,
> and I can't run xfs_repair on an image file that has smaller sector
> sizes than 4k without this mod. In that case, xfs_repair is doing
> direct IO on a file, not a device, and the file is on the 4k sector
> sized filesytem. I've been carrying this patch for a while.

Got it - you repair the image on directly on the device, without the
loop driver.

<Prev in Thread] Current Thread [Next in Thread>