xfs
[Top] [All Lists]

[PATCH 31/45] xfs: simplify xfs_qm_detach_gdquots

To: xfs@xxxxxxxxxxx
Subject: [PATCH 31/45] xfs: simplify xfs_qm_detach_gdquots
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 28 Oct 2011 05:54:54 -0400
References: <20111028095423.796574703@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: quilt/0.48-1
With the new lock order there is no reason to drop qi_dqlist_lock around
calls to xfs_qm_dqrele.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

---
 fs/xfs/xfs_qm.c |   22 +++++-----------------
 1 file changed, 5 insertions(+), 17 deletions(-)

Index: xfs/fs/xfs/xfs_qm.c
===================================================================
--- xfs.orig/fs/xfs/xfs_qm.c    2011-10-27 22:40:07.538179215 +0200
+++ xfs/fs/xfs/xfs_qm.c 2011-10-27 22:40:08.124671538 +0200
@@ -449,7 +449,6 @@ xfs_qm_detach_gdquots(
 {
        struct xfs_quotainfo    *q = mp->m_quotainfo;
        struct xfs_dquot        *dqp, *gdqp;
-       int                     nrecl;
 
  again:
        ASSERT(mutex_is_locked(&q->qi_dqlist_lock));
@@ -462,25 +461,14 @@ xfs_qm_detach_gdquots(
                        mutex_lock(&q->qi_dqlist_lock);
                        goto again;
                }
-               if ((gdqp = dqp->q_gdquot)) {
-                       xfs_dqlock(gdqp);
+
+               gdqp = dqp->q_gdquot;
+               if (gdqp)
                        dqp->q_gdquot = NULL;
-               }
                xfs_dqunlock(dqp);
 
-               if (gdqp) {
-                       /*
-                        * Can't hold the mplist lock across a dqput.
-                        * XXXmust convert to marker based iterations here.
-                        */
-                       nrecl = q->qi_dqreclaims;
-                       mutex_unlock(&q->qi_dqlist_lock);
-                       xfs_qm_dqput(gdqp);
-
-                       mutex_lock(&q->qi_dqlist_lock);
-                       if (nrecl != q->qi_dqreclaims)
-                               goto again;
-               }
+               if (gdqp)
+                       xfs_qm_dqrele(gdqp);
        }
 }
 

<Prev in Thread] Current Thread [Next in Thread>