xfs
[Top] [All Lists]

Re: [PATCH 6/8] xfstests: add fiemap operation to fsstress

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/8] xfstests: add fiemap operation to fsstress
From: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
Date: Thu, 03 Nov 2011 13:34:41 +0400
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, aelder@xxxxxxx, hch@xxxxxx, xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=dLwsTAGlNORnbrjoR6n6sTsxLFTO7B9Pl+rQ0rbdw9Q=; b=mMHg6PAfZdA3wVQT+qmg/T9KENicR/LLGRjvXX5jv8igNf9FRyf7OPlb1jrQKfOnTz BAJOitSnVy5ABcseCxuak9YN9QGAgcDZC4NXjeX/vKB/y6yqxPkaaECDMslB9zThCkVB C7WHIlzhCcsrUMLnkPQM41X0Vl+ZBeUPvdu64=
In-reply-to: <20111102195534.GB22500@xxxxxxxxxxxxx>
References: <1319849297-3506-1-git-send-email-dmonakhov@xxxxxxxxxx> <1319849297-3506-7-git-send-email-dmonakhov@xxxxxxxxxx> <20111102195534.GB22500@xxxxxxxxxxxxx>
Sender: Dmitry Monakhov <rjevskiy@xxxxxxxxx>
User-agent: Notmuch/0.5-69-g3e4a9d6 (http://notmuchmail.org) Emacs/23.1.1 (i486-pc-linux-gnu)
On Wed, 2 Nov 2011 15:55:34 -0400, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Sat, Oct 29, 2011 at 04:48:15AM +0400, Dmitry Monakhov wrote:
> > Related bug: http://patchwork.ozlabs.org/patch/118863
> > 
> > Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
> 
> This causes a very weird XFS failure in test 117 for me.  While it
> obviously is an xfs bug that you uncovered (good!) I'm a bit worried
> about simply enabling operations in existing tests.
Ohh. i've got what your are talking about. We can not add new ops
for tests there seed is passed explicitly. And yes i've braked this, but
this is because such frozen tests was written in not determined
way :). Good determined test should has not just seed opt, but also
explicit set of operations. All others (non determined) tests which use
fsstress may benefit from new ops. So I'll redo my patch queue like this:
1) Add explicit option set for all frozen tests
2) Add new features to fssstress with non zero probability. 
> 
> Alex, Eric, Dave - should we add new tests with the new operations
> Dmitry added, or is adding new ops to the existing tests fine?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>