xfs
[Top] [All Lists]

Re: [PATCH v2] xfs: Remove the entries from the queue while waking them

To: Ben Myers <bpm@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2] xfs: Remove the entries from the queue while waking them up
From: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Date: Tue, 29 Nov 2011 17:24:25 -0600
Cc: XFS Mailing List <xfs@xxxxxxxxxxx>
In-reply-to: <20111129153850.GU29840@xxxxxxx>
Organization: IBM
References: <1321918880.7115.5.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20111129153850.GU29840@xxxxxxx>
Reply-to: sekharan@xxxxxxxxxx
On Tue, 2011-11-29 at 09:38 -0600, Ben Myers wrote:
> Hey Chandra,
> 
> On Mon, Nov 21, 2011 at 05:41:20PM -0600, Chandra Seetharaman wrote:
> > Changes from Verion 1:
> > 
> > - Added additional comments as per Dave's suggestion
> > - Use next instead of tmp
> > - change typedef xlog_ticket_t to struct xlog_ticket
> > - Check t_queue before adding it to the list (the second time)
> >   to accomodate system events (based on Christoph's comments)
> 
> FWIW, I reproduced a log hang yesterday in xfstest 273 while testing

I didn't have test case 273 in my test directory (old copy). Ran the
tests and did see hang and some list corruption. I haven't gone further.

> this patch.  We'll have to see if Christoph's revision fares any better
> today.

I tried testcase 273 with Christoph patches and they are running fine
for few runs now.

I will run test cases 273 and 234 overnight with Christoph's patches and
report it tomorrow.

> 
> Thanks,
>       Ben
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 


<Prev in Thread] Current Thread [Next in Thread>