xfs
[Top] [All Lists]

Re: [PATCH] xfstests 273 274 275: do test in dedicated dir and leave tes

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests 273 274 275: do test in dedicated dir and leave test files in it
From: Eryu Guan <guaneryu@xxxxxxxxx>
Date: Sat, 28 Jan 2012 00:28:36 +0800
Cc: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=djQ3eHvJ+Sm9aWo5cCi7KKfzPhTBu3vfDV9CTlGuUsI=; b=J2ruKaltQvJsOqxlTQMadf53obqGjX8mgZMC3zMYgYnkHbK0TKPKI9s8d6Bomv+Ql8 m7eU6CmnlnPdGdigHKUKMkYhrJ22Y4sPlE0Ld9zN8s/Pa9rerGTR8HO+4khN4bTLkk+K PuQ/R7mfLyiS4eVGC7tTRjxlzjbvZk29xqHEI=
In-reply-to: <20120127110120.GA31093@xxxxxxxxxxxxx>
References: <1326388815-21181-1-git-send-email-guaneryu@xxxxxxxxx> <20120127110120.GA31093@xxxxxxxxxxxxx>
Reply-to: guaneryu@xxxxxxxxx
On Fri, Jan 27, 2012 at 7:01 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Fri, Jan 13, 2012 at 01:20:15AM +0800, Eryu Guan wrote:
>> Do all testings in dedicated dir($SCRATCH_MNT/$seq) instead of
>> $SCRATCH_MNT and don't remove test files in _cleanup() for debug
>> purpose.
>
> What it the dedicated directory useful for?

fsck.extN will complain lost+found is missing and fail 273. So my first try is
creating lost+found explicitly after removing everything in $SCRATCH_MNT.
Please see http://oss.sgi.com/archives/xfs/2012-01/msg00092.html
The whole point here is to avoid such fsck errors.

And as Dave suggested, 273 274 275 should put all files in a dedicated location
and just remove that dir instead of removing all files in
$SCRATCH_MNT. So I sent
out this as a second try. Perhaps I should mark it as v2...

Thanks,
Eryu Guan

<Prev in Thread] Current Thread [Next in Thread>