xfs
[Top] [All Lists]

[PATCH 3/8] quota: make Q_XQUOTASYNC a noop

To: xfs@xxxxxxxxxxx
Subject: [PATCH 3/8] quota: make Q_XQUOTASYNC a noop
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 19 Feb 2012 21:28:18 -0500
References: <20120220022815.018921977@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: quilt/0.48-1
Now that XFS takes quota reservations into account there is no need to flush
anything before reporting quotas - in addition to beeing fully transactional
all quota information is also 100% coherent with the rest of the filesystem
now.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Index: xfs/fs/quota/quota.c
===================================================================
--- xfs.orig/fs/quota/quota.c   2012-02-02 13:06:30.693396524 +0100
+++ xfs/fs/quota/quota.c        2012-02-02 13:23:23.181244741 +0100
@@ -282,10 +282,9 @@ static int do_quotactl(struct super_bloc
        case Q_XGETQUOTA:
                return quota_getxquota(sb, type, id, addr);
        case Q_XQUOTASYNC:
-               /* caller already holds s_umount */
                if (sb->s_flags & MS_RDONLY)
                        return -EROFS;
-               writeback_inodes_sb(sb, WB_REASON_SYNC);
+               /* XFS quotas are fully coherent now, making this call a noop */
                return 0;
        default:
                return -EINVAL;

<Prev in Thread] Current Thread [Next in Thread>