xfs
[Top] [All Lists]

Re: [PATCH 2/8] xfs: do not require an ioend for new EOF calculation

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/8] xfs: do not require an ioend for new EOF calculation
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 28 Feb 2012 10:14:27 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120221003906.313004161@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120221003824.415885674@xxxxxxxxxxxxxxxxxxxxxx> <20120221003906.313004161@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 02/20/12 18:38, Christoph Hellwig wrote:
Replace xfs_ioend_new_eof with a new inline xfs_new_eof helper that
doesn't require and ioend, and is available also outside of xfs_aops.c.

Also make the code a bit more clear by using a normal if statement
instead of a slightly misleading MIN().

Reviewed-by: Dave Chinner<dchinner@xxxxxxxxxx>
Signed-off-by: Christoph Hellwig<hch@xxxxxx>

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>