xfs
[Top] [All Lists]

Re: [PATCH 2/8] xfs: include reservations in quota reporting

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/8] xfs: include reservations in quota reporting
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 29 Feb 2012 13:37:57 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120220022903.684527645@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120220022815.018921977@xxxxxxxxxxxxxxxxxxxxxx> <20120220022903.684527645@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Feb 19, 2012 at 09:28:17PM -0500, Christoph Hellwig wrote:
> Report all quota usage including the currently pending reservations.  This
> avoids the need to flush delalloc space before gathering quota information,
> and matches quota enforcement, which already takes the reservations into
> account.
> 
> This fixes xfstests 270.
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

I'm a little concerned about large speculative delay block reservations
with this code, but that remains to be seen.

Looks good.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>