xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfsprogs: replace deprecated ustat call with statfs in l

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH 1/2] xfsprogs: replace deprecated ustat call with statfs in libxfs/linux.c
From: Kamal Dasu <kdasu.kdev@xxxxxxxxx>
Date: Mon, 5 Mar 2012 11:16:13 -0500
Authentication-results: mr.google.com; spf=pass (google.com: domain of kdasu.kdev@xxxxxxxxx designates 10.50.160.131 as permitted sender) smtp.mail=kdasu.kdev@xxxxxxxxx; dkim=pass header.i=kdasu.kdev@xxxxxxxxx
Cc: Kevin Cernekee <cernekee@xxxxxxxxx>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=K25qA4UkbkT1+0JdgdxhPr89WUPOYpV58Vdovq8ZSzw=; b=xUjZsFl+PdbURI4o1yR77lgKiRPQMUYCMozVjn8L/5L4SkIgbzC6ie5dB4sygLXxTH hwIHmCT49SR/xNNWdjZs69RE+hb8hobVkwdwBHjJutRhhZ8WrOJMB4h5J0KSOnhPeEbH tsLKpXz28rBl/bDDIlWz1pvG9haos8tWYG9LEgANoJZ/90sEcvQklOvcPtLjYItQPY79 OAQscnatyyM5nXqfHjk0uMmYjpL6cv57kOEJvegCujpWcmnkkbpcQIDS9veOKyt9Xpji 1U6WYiwb+52VMngUmMMRoa1LZFlwirm2/YRvLN7OYiHyNNJ295dylmR/YwLgg9hVCwYt ikag==
In-reply-to: <20120302074558.GB4117@xxxxxxxxxxxxx>
References: <1330636285-11200-1-git-send-email-kdasu.kdev@xxxxxxxxx> <de74feb44ebd887269fe85d9a5879765afccf4c2.1330635228.git.kdasu.kdev@xxxxxxxxx> <20120302074558.GB4117@xxxxxxxxxxxxx>
Christoph,

> More seriously - ustat provides the benefit to check if the block device
> is mounted anywhere, which we make use of here.  A statfs of the block
> device path doesn't provide that functionality at all.
>

Now I understand your concern. However if we would want to replace the
deprecated ustat call, then what other way would be acceptable to
achieve the same. Would parsing the /proc/mounts for the block device
name suffice ?.

Thanks
Kamal

On Fri, Mar 2, 2012 at 2:45 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Thu, Mar 01, 2012 at 04:11:24PM -0500, Kamal Dasu wrote:
>> >From the ustat man page
>>
>> NOTES
>>        ustat() is deprecated and has only  been  provided  for 
>>  compatibility.
>>        All new programs should use statfs(2) instead.
>
> xfsprogs isn't new :)
>
> More seriously - ustat provides the benefit to check if the block device
> is mounted anywhere, which we make use of here.  A statfs of the block
> device path doesn't provide that functionality at all.
>

<Prev in Thread] Current Thread [Next in Thread>