xfs
[Top] [All Lists]

Re: [PATCH 0/3] xfs: More xfs_buf cleanups

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 0/3] xfs: More xfs_buf cleanups
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 13 Apr 2012 22:02:42 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120411200821.GK28816@xxxxxxxxxxxxx>
References: <1334052213-26870-1-git-send-email-david@xxxxxxxxxxxxx> <20120411200821.GK28816@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Apr 11, 2012 at 04:08:22PM -0400, Christoph Hellwig wrote:
> On Tue, Apr 10, 2012 at 08:03:30PM +1000, Dave Chinner wrote:
> > These 3 patches sit on top of my recent series titled:
> > 
> > [PATCH 0/8] xfs: clean up unit usage in xfs_buf V2
> > 
> > These patches remove bits of the API that are effectively the
> > default behaviour used by everything or are redundant. This just
> > makes API usage simpler and gives it a smaller footprint to modify
> > in future.
> 
> If you touch these interfaces any chance you could kill the impliciy
> XBF_MAPPED thing we do in various places?  Probably best by reversing
> it and only pass in an XBF_UNMAPPED for the inode buffers as that's
> the only place where we want them.

Sounds like a good idea. I'll write a patch to do this....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>