xfs
[Top] [All Lists]

Re: [RFC]xfs: using GFP_NOFS for blkdev_issue_flush

To: Shaohua Li <shli@xxxxxxxxxx>
Subject: Re: [RFC]xfs: using GFP_NOFS for blkdev_issue_flush
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 17 Apr 2012 13:42:03 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <4F8BC30D.5040601@xxxxxxxxxx>
References: <4F8BC112.9090508@xxxxxxxxxxxx> <4F8BC30D.5040601@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 04/16/12 01:58, Shaohua Li wrote:

flush request is issued in transaction commit code path usually, so
looks using
GFP_KERNEL to allocate memory for flush request bio falls into the classic
deadlock issue (memory reclaim recursion). Use GFP_NOFS to avoid recursion
from reclaim context. Per Dave Chinner, there is only blkdev_issue_flush
might
be buggy here. But using GFP_NOFS by default for all calls should not
matter.

Signed-off-by: Shaohua Li <shli@xxxxxxxxxxxx>
---


Looks good.


Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>