xfs
[Top] [All Lists]

Re: [PATCH 29/37 V2] xfs: move busy extent handling to it's own file

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 29/37 V2] xfs: move busy extent handling to it's own file
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 24 Apr 2012 13:10:31 -0500
Cc: Ben Myers <bpm@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4F96CD24.2070805@xxxxxxx>
References: <1335160747-17254-1-git-send-email-david@xxxxxxxxxxxxx> <1335160747-17254-30-git-send-email-david@xxxxxxxxxxxxx> <20120423175725.GG16881@xxxxxxx> <20120424002502.GS9541@dastard> <4F96CD24.2070805@xxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 04/24/12 10:56, Mark Tinguely wrote:
On 04/23/12 19:25, Dave Chinner wrote:

From: Dave Chinner <dchinner@xxxxxxxxxx>

To make it easier to handle userspace code merges, move all the busy
extent handling out of the allocation code and into it's own file.
The userspace code does not need the busy extent code, so this
simplifies the merging of the kernel code into the userspace
xfsprogs library.

Because the busy extent code has been almost completely rewritten
over the past couple of years, also update the copyright on this new
file to include the authors that made all those changes.

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
---

Should xfs_alloc_busy_trim() be STATIC? It is defined in
xfs_extent_busy.c and used in xfs_alloc.c.

Same story for the next patch which renames this routine.

Thanks,

Mark Tinguely <tinguely@xxxxxxx>

FYI,

The routines in this patch call for struct xfs_busy_extent, but the xfs_extent_busy.h header file defines struct xfs_extent_busy.

I know this structure will get converted for the next patch.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>