xfs
[Top] [All Lists]

Re: [PATCH 28/37] xfs: move xfsagino_t to xfs_types.h

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 28/37] xfs: move xfsagino_t to xfs_types.h
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 29 Apr 2012 17:49:17 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1335160747-17254-29-git-send-email-david@xxxxxxxxxxxxx>
References: <1335160747-17254-1-git-send-email-david@xxxxxxxxxxxxx> <1335160747-17254-29-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Apr 23, 2012 at 03:58:58PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Untangle the header file includes a bit by moving the definition of
> xfs_agino_t to xfs_types.h. This removes the dependency that xfs_ag.h has on
> xfs_inum.h, meaning we don't need to include xfs_inum.h everywhere we include
> xfs_ag.h.

This patch by itself looks good to me, but is there any good reason to
keep xfs_inum.h around at all?

<Prev in Thread] Current Thread [Next in Thread>