xfs
[Top] [All Lists]

Re: [PATCH 37/37] xfs: make XBF_MAPPED the default behaviour

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 37/37] xfs: make XBF_MAPPED the default behaviour
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 30 Apr 2012 12:45:42 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120429215728.GP19889@xxxxxxxxxxxxx>
References: <1335160747-17254-1-git-send-email-david@xxxxxxxxxxxxx> <1335160747-17254-38-git-send-email-david@xxxxxxxxxxxxx> <20120429215728.GP19889@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Apr 29, 2012 at 05:57:28PM -0400, Christoph Hellwig wrote:
> > @@ -399,8 +399,9 @@ _xfs_buf_map_pages(
> >     if (bp->b_page_count == 1) {
> >             /* A single page buffer is always mappable */
> >             bp->b_addr = page_address(bp->b_pages[0]) + bp->b_offset;
> > -           bp->b_flags |= XBF_MAPPED;
> > -   } else if (flags & XBF_MAPPED) {
> > +   } else if (flags & XBF_UNMAPPED) {
> > +           bp->b_addr = NULL;
> 
> Do we need this explicit assigned?  The buffer should always have
> b_addr == NULL at this point.

True. I'll change it to an ASSERT.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>