xfs
[Top] [All Lists]

Re: [PATCH 5/7] xfs: refactor xfs_ialloc_ag_select

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/7] xfs: refactor xfs_ialloc_ag_select
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 18 Jun 2012 12:23:11 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120605144836.296927585@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120605144647.051012936@xxxxxxxxxxxxxxxxxxxxxx> <20120605144836.296927585@xxxxxxxxxxxxxxxxxxxxxx>
Resent-date: Mon, 18 Jun 2012 13:26:16 +1000
Resent-from: Dave Chinner <david@xxxxxxxxxxxxx>
Resent-message-id: <20120618032616.GS19223@dastard>
Resent-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jun 05, 2012 at 10:46:52AM -0400, Christoph Hellwig wrote:
> Loop over the in-core perag structures and prefer using pagi_freecount over
> going out to the AGI buffer where possible.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good. One minor thing:

> @@ -901,13 +897,13 @@ xfs_dialloc(
>       xfs_buf_t       **IO_agbp,      /* in/out ag header's buffer */
>       xfs_ino_t       *inop)          /* inode number allocated */
>  {
> +     xfs_mount_t     *mp = tp->t_mountp;

struct xfs_mount

Otherwise,

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>