On 07/10/2012 12:41 AM, Mark Tinguely wrote:
On 07/03/12 02:15, Jeff Liu wrote:
This is v3 of the patch.
We can trigger BUG() in xfs_seek_data() if met two unwritten without
data or hole extents at last version.
So making the extents map reading in loop could solve it.
Sorry, Am not yet try the repeated holes scenario according to Dave's
comments as lack of X64 test env, still
waiting for it ready. But this patch is already too long delayed, I
have worked it out one weeks ago.
So I'd like to post it because of it could handle repeated
hole/unwritten extents well in a loop, and I also improved
xfstests:286 with those cases for the verification, will post it soon.
Tested by Mark, hit BUG() for continuous unwritten extents without
* xfs_seek_data(), remove BUG() and having extents map search in loop.
suggested by Mark.
* xfs_has_unwritten_buffer(), use the input offset instead of
calculate page index for data buffer probing.
Signed-off-by: Jie Liu<jeff.liu@xxxxxxxxxx>
Nice. Up to refining xfs_seek_hole()?
Thanks for the review.
Sorry for my late response, I missed you this email.
Sure, the refinement will be reflected in next post. :)
Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>
xfs mailing list